Patches for improved xls/xlsx export/imports

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Patches for improved xls/xlsx export/imports

André Schild
Hello,

I just posted a patchset for allow exporting results into xlsx files
and at the same time allow importing xlsx files too.

I switched the support library from the outdate and no longer supported
JExcelApi
to the apache POI framework.

This allows us to work with xlsx files too and at the same time create
huge xlsx file with minimal memory requirements.

Any chances that my patchset gets applied to git?


The patch is available here:

https://sourceforge.net/p/squirrel-sql/bugs/625/


André


------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Squirrel-sql-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
Reply | Threaded
Open this post in threaded view
|

Re: Patches for improved xls/xlsx export/imports

Gerd Wagner-3
Hi André,

thanks for your patch. I just had a look at it. It contains only changes
to the Dataimport Plugin's ExcelFileImporter class. This class does not
affect Excel export but only import.

I would have expected changes to the DataExportExcelWriter class in our
fw modul. Is there something missing in your patch?


Gerd



On 11.11.2013 19:07, André Schild wrote:

> Hello,
>
> I just posted a patchset for allow exporting results into xlsx files
> and at the same time allow importing xlsx files too.
>
> I switched the support library from the outdate and no longer supported
> JExcelApi
> to the apache POI framework.
>
> This allows us to work with xlsx files too and at the same time create
> huge xlsx file with minimal memory requirements.
>
> Any chances that my patchset gets applied to git?
>
>
> The patch is available here:
>
> https://sourceforge.net/p/squirrel-sql/bugs/625/
>
>
> André
>
>
> ------------------------------------------------------------------------------
> November Webinars for C, C++, Fortran Developers
> Accelerate application performance with scalable programming models. Explore
> techniques for threading, error checking, porting, and tuning. Get the most
> from the latest Intel processors and coprocessors. See abstracts and register
> http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
> _______________________________________________
> Squirrel-sql-develop mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
>


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Squirrel-sql-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
Reply | Threaded
Open this post in threaded view
|

Re: Patches for improved xls/xlsx export/imports

André Schild
Hello Gerd,

Am 13.11.2013 22:12, schrieb Gerd Wagner:
> Hi André,
>
> thanks for your patch. I just had a look at it. It contains only
> changes to the Dataimport Plugin's ExcelFileImporter class. This class
> does not affect Excel export but only import.
>
> I would have expected changes to the DataExportExcelWriter class in
> our fw modul. Is there something missing in your patch?

Yes,

I did export only the patch for the plugin part... :(

But the patch2.patch attached to the bug is now including the patches
for all 5 files.

Thanks

André

------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Squirrel-sql-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
Reply | Threaded
Open this post in threaded view
|

Re: Patches for improved xls/xlsx export/imports

Gerd Wagner-3
Andre,

sorry for getting back to you so late and with such a trivial problem
but I've been quite busy lately.

The problem is that I can't find your patch. Please try to resend it to
me directly.

Thanks

Gerd


On 14.11.2013 22:39, André Schild wrote:

> Hello Gerd,
>
> Am 13.11.2013 22:12, schrieb Gerd Wagner:
>> Hi André,
>>
>> thanks for your patch. I just had a look at it. It contains only
>> changes to the Dataimport Plugin's ExcelFileImporter class. This class
>> does not affect Excel export but only import.
>>
>> I would have expected changes to the DataExportExcelWriter class in
>> our fw modul. Is there something missing in your patch?
>
> Yes,
>
> I did export only the patch for the plugin part... :(
>
> But the patch2.patch attached to the bug is now including the patches
> for all 5 files.
>
> Thanks
>
> André
>


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Squirrel-sql-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
Reply | Threaded
Open this post in threaded view
|

Re: Patches for improved xls/xlsx export/imports

André Schild
Hello Gerd,


Am 02.12.2013 21:06, schrieb Gerd Wagner:
> Andre,
>
> sorry for getting back to you so late and with such a trivial problem
> but I've been quite busy lately.
>
> The problem is that I can't find your patch. Please try to resend it
> to me directly.

It's attached to this bug
https://sourceforge.net/p/squirrel-sql/bugs/625/

And also attached to this mail.

With best regards

André

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Squirrel-sql-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop

patch2.patch (14K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patches for improved xls/xlsx export/imports

Gerd Wagner-3
On 02.12.2013 21:28, André Schild wrote:

> Hello Gerd,
>
>
> Am 02.12.2013 21:06, schrieb Gerd Wagner:
>> Andre,
>>
>> sorry for getting back to you so late and with such a trivial problem
>> but I've been quite busy lately.
>>
>> The problem is that I can't find your patch. Please try to resend it
>> to me directly.
>
> It's attached to this bug
> https://sourceforge.net/p/squirrel-sql/bugs/625/
>
> And also attached to this mail.

Your patch has been applied to our Git repository. It will be included
in future snapshots and versions.

Thanks a lot

Gerd


------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Squirrel-sql-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop